[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: FYI wc-queries.h - file format questionable?

From: Greg Stein <gstein_at_gmail.com>
Date: Wed, 26 Oct 2011 17:24:53 -0400

On Wed, Oct 26, 2011 at 16:37, NormW <normw_at_gknw.net> wrote:
>...
> What my compiler is grumbling about is more that quoted text continues from
> line to line (and likely not using a \ to do it); the following creates the
> warning:
>>
>>  "SELECT op_depth, repos_id, repos_path, presence, kind, revision,
>> checksum,
>>  " \

Oh! That is definitely wrong. There should be newlines within the
string text (which is the case on my machine).

I wonder if that is due to newline style? ... Looking at the code, I
bet it is. transform_sql splits on '\n'. But I bet there is an extra
'\r' in there causing those newlines.

Can you try changing line 132 to include a .strip() in there? It
should look like:
        self.output.write(' "%s " \\\n' % line.strip())

Stripping off the whitespace should not be a problem since we there is
an extra space added back in, before the closing quote.

>...
> As previous, mention it as an 'experience' rather than a bug as no one else
> seems to have raised it. Just the 2nd format drops my build log for
> subversion from 961k to 62k.

I'd call it a bug, if there are newlines within the quotes. Please try
the above, and see if that fixes it.

Cheers,
-g
Received on 2011-10-26 23:25:25 CEST

This is an archived mail posted to the Subversion Dev mailing list.