[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: Breakage in Status API

From: Mark Phippard <markphip_at_gmail.com>
Date: Wed, 26 Oct 2011 08:31:01 -0400

On Wed, Oct 26, 2011 at 8:19 AM, Bert Huijben <bert_at_qqmail.nl> wrote:

>> 1) The status API changed in 1.7 to report 3 statuses back
>>   - Since this was missed in JavaHL we will need to rev this in 1.8 so
>> that JavaHL reports the 3 statuses.
>
> I don't know about the JavaHL compatibility guarantees; maybe we can still
> add this.

As much as I would like to, I do not think we could backport a change
like this. We might even be faced with adding a Status2 object in 1.8
because otherwise the semantics of getTextStatus will change which
would also be a breakage. We might be able to solve this by adding
new methods like getTextStatus2 (for lack of better name) that return
the new textStatus where as the existing method would have to always
return the compatibility value.

>
>> 2) In libsvn_client where we need to maintain backwards compat the 3
>> statuses are turned back into the values they would have had with the
>> old 2 statuses.
>>   - The C++ part of JavaHL did NOT make the same backwards compat
>> change.  So this is something needs to be fixed for 1.7.x and should
>> be possible to fix?
>
> This should at least be done for the tigris package. For the apache package
> we should either fix this in the same way as for tigris or add the new
> status.

I think this change should be done first (for both packages) so we can
nominate it for backport. We can look into adding the node status and
deal with those ramifications later.

-- 
Thanks
Mark Phippard
http://markphip.blogspot.com/
Received on 2011-10-26 14:31:43 CEST

This is an archived mail posted to the Subversion Dev mailing list.