[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1181090 - Follow-up to r1180154: svn_rangelist_merge2 optimization.

From: Julian Foad <julian.foad_at_wandisco.com>
Date: Thu, 20 Oct 2011 15:45:16 +0100

Hi Paul.

It looks like we can simplify this by omitting the first branch of the
if ... else ... else construct:

[[[
       if (delete_index == (arr->nelts - 1))
         {
           /* Deleting the last or only element in an array is easy. */
           apr_array_pop(arr);
         }
+ else if ((delete_index + elements_to_delete) == arr->nelts)
+ {
+ /* Delete the last ELEMENTS_TO_DELETE elements. */
+ arr->nelts -= elements_to_delete;
+ }
       else
]]]

Or is there some reason why 'apr_array_pop' is preferred in the N==1 case?

- Julian
Received on 2011-10-20 16:45:50 CEST

This is an archived mail posted to the Subversion Dev mailing list.