RE: svn commit: r1181040 - in /subversion/branches/tree-read-api/subversion: include/svn_ra.h libsvn_ra/ra_loader.c

> -----Original Message-----
> From: julianfoad_at_apache.org [mailto:julianfoad_at_apache.org]
> Sent: maandag 10 oktober 2011 8:52
> To: commits_at_subversion.apache.org
> Subject: svn commit: r1181040 - in /subversion/branches/tree-read-
> api/subversion: include/svn_ra.h libsvn_ra/ra_loader.c
>
> Author: julianfoad
> Date: Mon Oct 10 15:52:23 2011
> New Revision: 1181040
>
> URL: http://svn.apache.org/viewvc?rev=1181040&view=rev
> Log:
> On the 'tree-read-api' branch: Implement svn_ra_get_symlink() and make
> svn_ra_check_path2() support symlinks.
>
> * subversion/include/svn_ra.h
> (svn_ra_get_symlink): New function.
>
> * subversion/libsvn_ra/ra_loader.c
> (svn_ra_get_symlink): New function.
> (svn_ra_check_path2): Use svn_ra_get_symlink() to detect symlinks.

If you intend to merge this code back to trunk eventually:

I think it would be better if svn_ra_check_path2 uses a single new/updated call to get the right information. This change makes svn_ra_check_path2() twice as slow as svn_ra_check_path() for the very common case where the target is a file. (And svn_ra_check_path is often just used to check if the path exists)

        Bert
Received on 2011-10-10 18:40:26 CEST