Re: svn commit: r1172652 - in /subversion/trunk/subversion: include/private/svn_subr_private.h libsvn_subr/spillbuf.c

On 09/19/2011 10:58 AM, gstein_at_apache.org wrote:
> Author: gstein
> Date: Mon Sep 19 14:58:47 2011
> New Revision: 1172652
>
> URL: http://svn.apache.org/viewvc?rev=1172652&view=rev
> Log:
> Add a new "spill buffer" type and functions, extracted from ra_serf. This
> type will buffer content in memory until it reaches a specified size,
> where it will then spill additional content onto disk.

Awesome. Wanna drop an exemplary use thereof into
subversion/libsvn_repos/reporter.c (for use with the
report_baton_t->tempfile member)? I've been wanting to make that change for
some time now, and this would prove a good demonstration of your new logic.

> Added: subversion/trunk/subversion/include/private/svn_subr_private.h
> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/include/private/svn_subr_private.h?rev=1172652&view=auto
> ==============================================================================
> --- subversion/trunk/subversion/include/private/svn_subr_private.h (added)
> +++ subversion/trunk/subversion/include/private/svn_subr_private.h Mon Sep 19 14:58:47 2011
> @@ -0,0 +1,86 @@
> +/*
> + * svn_subr_privae.h : private definitions from libsvn_subr

                   ^^ Oops!

I didn't complete a full review, just a skim. Looks good!

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand