[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: FSFS caching and ra_local

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Fri, 16 Sep 2011 19:42:10 +0100

Philip Martin <philip.martin_at_wandisco.com> writes:

> At startup the command line client disables the new FSFS caching in
> subversion/svn/main.c:main (I recall that at one point FSFS cache
> initialisation was expensive but I believe that is no longer the case):
>
> /* Per default, disable large expensive FS caching on the client side.
> * We can still chose a different size for that cache later in the
> * startup phase, e.g. after reading config files. If that does not
> * happen until the first FSFS repository get opened, low initialization
> * overhead caches will be used for the most time-critical structures.
> *
> * This is only relevant for FSFS over ra_local. */
> settings = *svn_cache_config_get();
> settings.cache_size = 0x0;
> svn_cache_config_set(&settings);
>
> but I don't see where we ever set it to a non-zero value or how we allow
> the user to control the cache size.
>
> Have we forgotten to do that bit? At the very least I think we should
> have a config setting.

r1171708 enables FSFS caching in the command line client by default and
introduces config:miscellaneous:memory-cache-size. I need to check
whether programs such as svnadmin that have a -M option should also
check the config option.

-- 
uberSVN: Apache Subversion Made Easy
http://www.uberSVN.com
Received on 2011-09-16 20:42:47 CEST

This is an archived mail posted to the Subversion Dev mailing list.