[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1170836 - in /subversion/trunk/subversion: include/ libsvn_client/ libsvn_delta/ libsvn_ra_neon/ libsvn_ra_serf/ libsvn_ra_svn/ libsvn_repos/ libsvn_wc/ svnrdump/ svnsync/ tests/libsvn_delta/

From: Hyrum K Wright <hyrum.wright_at_wandisco.com>
Date: Wed, 14 Sep 2011 20:30:03 -0500

On Wed, Sep 14, 2011 at 5:06 PM, Daniel Shahaf <d.s_at_daniel.shahaf.name> wrote:
> hwright_at_apache.org wrote on Wed, Sep 14, 2011 at 20:28:39 -0000:
>> @@ -240,12 +243,19 @@ ev2_change_dir_prop(void *dir_baton,
>>                      apr_pool_t *scratch_pool)
>>  {
>>    struct ev2_dir_baton *db = dir_baton;
>> -  struct prop_args *p_args = apr_palloc(db->eb->edit_pool, sizeof(*p_args));
>>
>> -  p_args->name = apr_pstrdup(db->eb->edit_pool, name);
>> -  p_args->value = value ? svn_string_dup(value, db->eb->edit_pool) : NULL;
>> +  if (value)
>> +    {
>> +      struct prop_args *p_args = apr_palloc(db->eb->edit_pool, sizeof(*p_args));
>> +
>> +      p_args->name = apr_pstrdup(db->eb->edit_pool, name);
>> +      p_args->value = value ? svn_string_dup(value, db->eb->edit_pool) : NULL;
>
> The NULL will never be evaluated.  (also in ev2_change_file_prop())

Good catch, fixed in r1170915.

> The rest looks good.

Thanks. In spite of my prickly attitude a couple of days ago, I do
appreciate the review. :)

-Hyrum

-- 
uberSVN: Apache Subversion Made Easy
http://www.uberSVN.com/
Received on 2011-09-15 03:30:38 CEST

This is an archived mail posted to the Subversion Dev mailing list.