[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Speed up client by re-using RA session connections

From: Daniel Shahaf <danielsh_at_elego.de>
Date: Wed, 14 Sep 2011 18:29:53 +0300

Julian Foad wrote on Wed, Sep 14, 2011 at 16:07:19 +0100:
> Enable libsvn_client APIs to re-use a previous RA session instead of always
> opening a new connection.
> Basically:
> - Declare an opaque "RA session cache" object in the public API. It holds
> one open RA session per repository, for any number of repositories.

Why per repository? What about a client that runs 'svn update' on several
wc's of the same URL concurrently?

> - Implement a private API for libsvn_client functions to use instead of
> simply opening a new session. It re-uses a session from the cache, if
> present, or opens a new connection if necessary.

As far as I can see, the "get a session from the cache" code assumes
that the cache is used by a single thread. (Consider what happens if
one thread retrieves or uses a cached session while another retrieves
the same session from the cache.) Will the cache be thread-safe?
Received on 2011-09-14 17:30:49 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.