[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1166489 - /subversion/branches/fs-successor-ids/subversion/libsvn_fs_fs/fs_fs.c

From: Daniel Shahaf <danielsh_at_elego.de>
Date: Thu, 8 Sep 2011 13:39:01 +0300

Stefan Sperling wrote on Thu, Sep 08, 2011 at 10:36:13 +0200:
> I probably would have used FSFS_SUCCESSORS_FILES_PER_SHARD
> instead of FSFS_SUCCESSORS_REVISIONS_PER_SHARD, and then
> computed the filename based on that number. I don't like
> thinking of it in terms of "revisions per shard" because
> the numbers get so big :)

First of all, the "big" numbers are 12(decimal) or 35(decimal), not more.

Second of all, I don't even think about the big numbers _at all_.
When I see

    (revision % FSFS_SUCCESSORS_REVISIONS_PER_SHARD)
    / ffd->max_files_per_dir,

I parse the parenthesized expression as "the index of 'revision'
within its shard"; but I don't work out its value.
Received on 2011-09-08 12:40:14 CEST

This is an archived mail posted to the Subversion Dev mailing list.