Re: svn commit: r1166247 - in /subversion/branches/fs-successor-ids/subversion/libsvn_fs_fs: fs.h fs_fs.c
From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Wed, 07 Sep 2011 19:31:05 +0300
On Wednesday, September 07, 2011 4:16 PM, stsp_at_apache.org wrote:
That doesn't look right. You're assuming this trick sets new_index[0..3], but can't it set new_index[3..7]?
I can think of several ways to do this that don't run into this bug (using a union, using inline code to get the individual bytes of FSFS_SUCCESSORS_INDEX_SIZE, or even write_full(&int), write_full(new_index + 8, sizeof(new_index)-8)). Of these three one is probably buggy, but at least one ought to be correct.
> + SVN_ERR(svn_io_file_write_full(file, new_index, sizeof(new_index), NULL,
This is an archived mail posted to the Subversion Dev mailing list.