[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1166184 - /subversion/branches/fs-successor-ids/subversion/libsvn_fs_fs/fs_fs.c

From: Daniel Shahaf <danielsh_at_elego.de>
Date: Wed, 7 Sep 2011 17:54:16 +0300

Stefan Sperling wrote on Wed, Sep 07, 2011 at 16:46:21 +0200:
> On Wed, Sep 07, 2011 at 05:19:19PM +0300, Daniel Shahaf wrote:
> > This will assert with
> >
> > % cat $REPOS/db/format
> > 6
> > layout linear
> > %
>
> Good catch. The assert() is from code I copy-pasted. Will look into it.

You need to decide at what level to check the format number. For
example, in make_successor_dirs() you check the format number in the
function itself; the other option is to assert() the format number in
the function and check it at the caller, and I believe that's what I did
last time I had to make that call.
Received on 2011-09-07 16:55:14 CEST

This is an archived mail posted to the Subversion Dev mailing list.