[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: SQL indices a WC format bump and 1.7

From: Greg Stein <gstein_at_gmail.com>
Date: Fri, 2 Sep 2011 19:05:15 -0400

On Fri, Sep 2, 2011 at 18:32, Peter Samuelson <peter_at_p12n.org> wrote:
>
> [Greg Stein]
>> Since we are selecting only "current nodes" for each local_relpath,
>> then I presume we don't need the apr_hash_get() in there, correct?
>
> Yeah, I confirmed with him on IRC that the wc_db.c change (chiefly
> deleting the extraneous apr_hash_get() call) is a cleanup that could be
> applied separately.  I could go either way.  It is a micro-optimization
> on a set of changes whose original purpose was optimization.

Oh! Whoops. My diff was backwards. I thought the apr_hash_get() was
being *added* ... but that's not the case.

Sure, this little optimization is just fine.

Cheers,
-g
Received on 2011-09-03 01:05:43 CEST

This is an archived mail posted to the Subversion Dev mailing list.