[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

AW: no error message if committing child of a deleted node

From: Markus Schaber <m.schaber_at_3s-software.com>
Date: Fri, 29 Jul 2011 13:48:13 +0200

Hi, Bert,

Von: Bert Huijben [mailto:bert_at_qqmail.nl]
> > Von: Stefan Sperling [mailto:stsp_at_elego.de]
> > > On Fri, Jul 29, 2011 at 08:14:58AM +0200, Markus Schaber wrote:
> > > > Von: Stefan Sperling [mailto:stsp_at_elego.de]
> > > >
> > > > > When trying to commit a child of a deleted node, svn commit
says
> > > > > nothing and just exists with status zero.
> > > > >
> > > > > This surprised me, because it complains loudly about
committing
> > > > > children of copies (see http://svn.haxx.se/dev/archive-2011-
> > > 07/0773.shtml).
> > > > > Shouldn't we raise some sort of error for the delete case,
too?
> > > >
> > > > For me, this is not as surprising. Chidren of deleted nodes are
> > > > also deleted. And it perfectly makes sense for the server to get
> > > > the deletion of the child without getting the deletion of the
> parent.
> > > >
> > > > But getting the addition of a copied child without getting its
> > > > (not-yet existing) parent is a completely different thing.
> > >
> > > Yes to all that, but why shouldn't Subversion at least point out
> > > that "Cannot commit bar/foo because it is a child of the deleted
> > > directory
> > bar;
> > > you must commit bar instead"?
> > > The structure of the local change is clearly incompatible with
what
> > the
> > > user attempts to commit in this case.
> >
> > There is no conceptual reason to forbid the commit of a child of a
> > deleted directory. The right thing to do here is to send the
deletion
> > of the child to the server.
>
> This is not that simple as you state. The child might have been
switched
> to a different url (and some descendants to even other urls).
>
> Would you like that url to be deleted, while a commit of the root of
the
> delete has never done that?

I expect the same thing to happen with the child as if only the child
was scheduled for deletion (but not the parent), and then I commit the
deletion of the child.

As far as I can see, committing the deletion of the child should not be
influenced by the fact that the parent is deleted, modified or whatever
else.

The user explicitly selected that deleted child for commit. (The rules
for children included by recursion / depth are different.)

Best regards

Markus Schaber

___________________________
We software Automation.

3S-Smart Software Solutions GmbH
Markus Schaber | Developer
Memminger Str. 151 | 87439 Kempten | Germany | Tel. +49-831-54031-0 |
Fax +49-831-54031-50

Email: m.schaber@3s-software.com | Web: http://www.3s-software.com
CoDeSys internet forum: http://forum.3s-software.com
Download CoDeSys sample projects:
http://www.3s-software.com/index.shtml?sample_projects

Managing Directors: Dipl.Inf. Dieter Hess, Dipl.Inf. Manfred Werner |
Trade register: Kempten HRB 6186 | Tax ID No.: DE 167014915
Received on 2011-07-29 13:49:05 CEST

This is an archived mail posted to the Subversion Dev mailing list.