[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1149675 - in /subversion/trunk/subversion: libsvn_repos/hooks.c libsvn_subr/io.c

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Fri, 22 Jul 2011 22:42:51 +0300

Lieven Govaerts wrote on Fri, Jul 22, 2011 at 20:50:07 +0200:
> On Fri, Jul 22, 2011 at 8:06 PM, <danielsh_at_apache.org> wrote:
> > Author: danielsh
> > Date: Fri Jul 22 18:06:12 2011
> > New Revision: 1149675
> >
> > URL: http://svn.apache.org/viewvc?rev=1149675&view=rev
> > Log:
> > Add error checking.  This manifested as a segfault and a file descriptor leak
> > in svnsync of an ra_serf source to an ra_local target.
> >
>
> Just to be clear on the wording here: this change does not solve the
> file descriptor leak, but does solve the segfault resulting from a
> file descriptor leak, currently still in the code. Right?
>

That's correct.

> Tested the fix with success on Mac OS X.
>
> Lieven
>
> > * subversion/libsvn_subr/io.c
> >  (svn_io_start_cmd2): Check the return value of apr_procattr_io_set().
> >
> > * subversion/libsvn_repos/hooks.c
> >  (run_hook_cmd): Do not try to use CMD_PROC when it may not have been initialized.
> >
> > Modified:
> >    subversion/trunk/subversion/libsvn_repos/hooks.c
> >    subversion/trunk/subversion/libsvn_subr/io.c
Received on 2011-07-22 21:43:51 CEST

This is an archived mail posted to the Subversion Dev mailing list.