[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1149228 - /subversion/trunk/subversion/libsvn_client/merge.c

From: Paul Burba <ptburba_at_gmail.com>
Date: Fri, 22 Jul 2011 10:53:00 -0400

On Thu, Jul 21, 2011 at 5:04 PM, Greg Stein <gstein_at_gmail.com> wrote:
> On Thu, Jul 21, 2011 at 11:37,  <pburba_at_apache.org> wrote:
>>...
>> +++ subversion/trunk/subversion/libsvn_client/merge.c Thu Jul 21 15:37:21 2011
>>...
>> @@ -8155,8 +8163,8 @@ remove_noop_subtree_ranges(const char *u
>>
>>   APR_ARRAY_PUSH(log_targets, const char *) = "";
>>
>> -  SVN_ERR(svn_ra_get_log2(ra_session, log_targets, youngest_gap_rev->end,
>> -                          oldest_gap_rev->start + 1, 0, TRUE, TRUE, FALSE,
>> +  SVN_ERR(svn_ra_get_log2(ra_session, log_targets, oldest_gap_rev->start + 1,
>> +                          youngest_gap_rev->end, 0, TRUE, TRUE, FALSE,
>>                           apr_array_make(scratch_pool, 0,
>>                                          sizeof(const char *)),
>>                           log_noop_revs, &log_gap_baton, scratch_pool));
>
> Given the sensitivity of the overall algorithm to ordering, I think
> that call deserves an explanatory comment about why the logs are
> ordered that way.

Quite right. Done r1149626.

Paul

> Cheers,
> -g
>
Received on 2011-07-22 16:53:36 CEST

This is an archived mail posted to the Subversion Dev mailing list.