[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [BUG] svnsync segfault

From: Lieven Govaerts <svnlgo_at_mobsol.be>
Date: Fri, 22 Jul 2011 11:08:04 +0200

On Fri, Jul 22, 2011 at 10:54 AM, Philip Martin
<philip.martin_at_wandisco.com> wrote:
> Lieven Govaerts <svnlgo_at_mobsol.be> writes:
>
>> when syncing the first ~200 revisions from the asf repository over
>> ra_serf to ra_local, svnsync segfaults when invoking the
>> pre-revprop-change hook of the local target repo.
>>
>> Not really at home in this part of the code, so if anyone can point me
>> in the right direction that would be appreciated.
>
> Does it happen on the first revision? At random?
>
On my mac usually after 200 revisions or so. Daniel's patch suggests a
link between this number and the max. amount of open file handles,
which is:
lgo-macbp:trunk lgo$ ulimit -n
256

Lieven

>> #0 0x00000001006b7d04 in apr_file_name_get ()
>
> Either it's an APR bug (not initialising fname) or we passed an invalid
> apr_file_t file handle.
>
>> #1 0x000000010051ce29 in stringbuf_from_aprfile
>> (result=0x7fff5fbfe7b0, filename=0x0, file=0x0, check_size=1,
>> pool=0x104541028) at subversion/libsvn_subr/io.c:2027
>> #2 0x000000010051d18a in svn_stringbuf_from_aprfile
>> (result=0x7fff5fbfe7b0, file=0x0, pool=0x104541028) at
>> subversion/libsvn_subr/io.c:2106
>> #3 0x000000010003bfc4 in check_hook_result (name=0x100054eaa
>> "pre-revprop-change", cmd=0x104541438
>> "/tmp/asfrepo/hooks/pre-revprop-change", cmd_proc=0x7fff5fbfe860,
>> read_errhandle=0x0, pool=0x104541028) at
>> subversion/libsvn_repos/hooks.c:71
>> #4 0x000000010003c47f in run_hook_cmd (result=0x0, name=0x100054eaa
>> "pre-revprop-change", cmd=0x104541438
>> "/tmp/asfrepo/hooks/pre-revprop-change", args=0x7fff5fbfe900,
>> stdin_handle=0x104541548, pool=0x104541028) at
>> subversion/libsvn_repos/hooks.c:210
>
> Here run_hook_cmd has called svn_io_start_cmd2 and it did not return an
> error, so it should have set cmd_proc.err to a valid apr_file_t.
>
>> #5 0x000000010003d057 in svn_repos__hooks_pre_revprop_change
>> (repos=0x10107e590, rev=199, author=0x101095c08 "lgo",
>> name=0x1044e61d8 "svn:author", new_value=0x104555040, action=77 'M',
>> pool=0x104541028) at subversion/libsvn_repos/hooks.c:516
>
> --
> uberSVN: Apache Subversion Made Easy
> http://www.uberSVN.com
>
Received on 2011-07-22 11:09:06 CEST

This is an archived mail posted to the Subversion Dev mailing list.