[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Lock token encoding (was Re: svn commit: r1147882 - /subversion/trunk/subversion/libsvn_repos/hooks.c)

From: Ivan Zhakov <ivan_at_visualsvn.com>
Date: Tue, 19 Jul 2011 11:49:29 +0400

On Mon, Jul 18, 2011 at 23:50, Daniel Shahaf <d.s_at_daniel.shahaf.name> wrote:
> Ivan notes on IRC that this fixes issues with non-ASCII lock tokens.
> (At least, he reports errors in 'svn ls -v' over http://; but for me
> 'ls' and 'info' work fine over svn://.)
> Are lock tokens even permitted to be non-ASCII?
> (both backends generate ASCII-only lock tokens (in the same manner))
> If they are, are they required to be in UTF-8?  Or can they be, say,
> arbitrary octet strings?
I didn't find explicit specification for lock token encoding, but it
handled everywhere as normal utf-8 string.

That's why I decided to implement minimum patch just to decide lock
token returned from hook output to utf-8 string.

But I'm fine to require lock token to be ASCII only string.

Ivan Zhakov
Received on 2011-07-19 09:50:44 CEST

This is an archived mail posted to the Subversion Dev mailing list.