[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: 1.7.0-beta1 up for testing / signing

From: Philip Martin <philip.martin_at_wandisco.com>
Date: Fri, 15 Jul 2011 16:05:07 +0100

Peter Samuelson <peter_at_p12n.org> writes:

> My patch is pretty crude, to Makefile.in:
>
> $(SWIG_PL_DIR)/native/Makefile: $(SWIG_PL_DIR)/native/Makefile.PL
> - cd $(SWIG_PL_DIR)/native; $(PERL) Makefile.PL
> + cd $(SWIG_PL_DIR)/native; \
> + $(PERL) Makefile.PL INSTALLDIRS=vendor; \
> + sed -i -e '/^LD_RUN_PATH/s/^/#/' Makefile Makefile.[a-z]*
>
> Basically it comments out the LD_RUN_PATH = ... line from the family of
> Makefiles. (Adding 'INSTALLDIRS=vendor' is also needed here, but is
> not part of the RPATH fix.) One would think a cleaner solution could
> be found, working _with_ ExtUtils::MakeMaker instead of against it.

So that removes RPATH from the shared objects in the build dir as well
as the install dir? Do the tests still work?

> Besides being crude, it uses sed -i, which works on my platform but is
> not portable. (Portable is to redirect sed to a temp file and then
> rename it to the original, which here would involve a shell loop.)

Since we must have perl

     $(PERL) -pi -e 's/..../'

should be portable.

-- 
uberSVN: Apache Subversion Made Easy
http://www.uberSVN.com
Received on 2011-07-15 17:05:47 CEST

This is an archived mail posted to the Subversion Dev mailing list.