[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Improve reporting WC is locked/busy ('run cleanup')

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Thu, 14 Jul 2011 19:31:55 +0300

Julian Foad wrote on Thu, Jul 14, 2011 at 12:58:24 +0100:
> When the work queue is not empty, we see:
>
> $ svn status
> svn: E155037: Previous operation has not finished; run 'cleanup' if it
> was interrupted
>
>
> My recommendations, mainly for the WQ-not-empty case:
>
> 1. The 'E155037' message shown above comes from libsvn_wc. But the
> part about running 'cleanup' should be added by 'svn', since in other
> clients it may have a different name or may not be applicable at all,
> especially if the client can find out that in fact the other operation
> is still running. So libsvn_wc would say just:
>
> "A previous operation on the working copy has not finished"
>
> and 'svn' would wrap that in:
>
> "Run 'svn cleanup' if the previous operation was interrupted"

The message says 'cleanup', not 'svn cleanup', and I believe last time
it was discussed the conclusion was to leave it that way and not cater
to clients that confuse people by deviating from the standard documented
names for operations.

(It's not very useful to have a library of consumers of that library
presents its APIs under different names in their UIs... like having two
pizzerias that each call "A person-sized pizza with peperonni" by
a different name; and then telling people that they can checkout[1]
their dinner in one and commit[1] it in another.)

[1] oops, the diner should SEGV on reading this word...
Received on 2011-07-14 18:33:57 CEST

This is an archived mail posted to the Subversion Dev mailing list.