[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r1144478 - in /subversion/branches/revprop-packing/subversion: include/svn_io.h libsvn_subr/stream.c tests/libsvn_subr/stream-test.c

From: Bert Huijben <bert_at_qqmail.nl>
Date: Thu, 14 Jul 2011 10:41:37 +0200

> -----Original Message-----
> From: Julian Foad [mailto:julian.foad_at_wandisco.com]
> Sent: donderdag 14 juli 2011 10:35
> To: dev_at_subversion.apache.org; Hyrum Wright
> Subject: Re: svn commit: r1144478 - in /subversion/branches/revprop-
> packing/subversion: include/svn_io.h libsvn_subr/stream.c
> tests/libsvn_subr/stream-test.c
>
> On Fri, 2011-07-08, hwright_at_apache.org wrote:
> > New Revision: 1144478
> >
> > URL: http://svn.apache.org/viewvc?rev=1144478&view=rev
> > Log:
> > On the revprop-packing branch:
> > Rev the svn_stream_copy3() API and give it an argument which allows the
> caller
> > to specify the number of bytes to copy.
>
> I notice we have about 24 existing callers of svn_stream_copy3(), and I
> don't suppose any of them want to specify the number of bytes to copy,
> so I think this might be better as a separate API with a new name rather
> than a revision of the existing API.

+1
And I don't think there will be many new callers that want to limit the number of bytes to copy.

(Although I remember that we had a specialized stream that limited the number of bytes readable in early 1.7 development)

        Bert
Received on 2011-07-14 10:42:23 CEST

This is an archived mail posted to the Subversion Dev mailing list.