[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r1145972 - in /subversion/trunk/subversion: libsvn_wc/wc-queries.sql libsvn_wc/wc_db.c svn/changelist-cmd.c tests/cmdline/changelist_tests.py tests/cmdline/tree_conflict_tests.py

From: Bert Huijben <bert_at_qqmail.nl>
Date: Thu, 14 Jul 2011 09:21:56 +0200

> -----Original Message-----
> From: Noorul Islam K M [mailto:noorul_at_collab.net]
> Sent: donderdag 14 juli 2011 7:15
> To: dev_at_subversion.apache.org
> Subject: Re: svn commit: r1145972 - in /subversion/trunk/subversion:
> libsvn_wc/wc-queries.sql libsvn_wc/wc_db.c svn/changelist-cmd.c
> tests/cmdline/changelist_tests.py tests/cmdline/tree_conflict_tests.py

> > +
> > + if (!success)
> > + return svn_error_create(SVN_ERR_ILLEGAL_TARGET, NULL,
> > + _("Could not display info for all targets
because "
> > + "some targets don't exist"));
>
> I think this should be something like this.
>
> Could not add all targets to changelist because some targets don't exist
>
> I will add test cases for handling multiple targets.

I just copied the (already translated) message that most other commands use.

Technically the current text is correct, but I agree that it could be
improved.

>
> > + else
> > + return SVN_NO_ERROR;
> > }
> >
> > Modified: subversion/trunk/subversion/tests/cmdline/changelist_tests.py
> > URL:
> http://svn.apache.org/viewvc/subversion/trunk/subversion/tests/cmdline/c
> hangelist_tests.py?rev=1145972&r1=1145971&r2=1145972&view=diff
> >
> ==========================================================
> ====================
> > --- subversion/trunk/subversion/tests/cmdline/changelist_tests.py
> (original)
> > +++ subversion/trunk/subversion/tests/cmdline/changelist_tests.py Wed
> Jul 13 12:28:17 2011
> > @@ -1132,6 +1132,43 @@ def revert_deleted_in_changelist(sbox):
> > 'revert', '-R', sbox.ospath('A'))
> > svntest.actions.run_and_verify_info(expected_infos,
> sbox.ospath('A/mu'))
> >
> > +def add_remove_non_existent_target(sbox):
> > + "add and remove non-existent target to changelist"
> > +
> > + sbox.build(read_only = True)
> > + wc_dir = sbox.wc_dir
> > + bogus_path = os.path.join(wc_dir, 'A', 'bogus')
> > +
> > + expected_err = "svn: warning: W155010: The node '" + \
> > + re.escape(os.path.abspath(bogus_path)) + \
> > + "' was not found"
>
> This is actually different from what 1.6 displays. Is this fine?

- *All* errors and warnings from 'svn' are different from what 1.6 displays
as we added the error number for 1.7.
- Almost every error that talks about entries is replaced with something
that talks about nodes.
- And many errors now display absolute paths.

And I don't think we ever promised that the errors would be identical.

With this patch I just made sure that we return an error so scripts can rely
on just checking the exitcode instead of having to parse 'some warning'

        Bert
Received on 2011-07-14 09:22:46 CEST

This is an archived mail posted to the Subversion Dev mailing list.