[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] [perl bindings] Bizarre copy of UNKNOWN in subroutine

From: Stefan Sperling <stsp_at_elego.de>
Date: Mon, 11 Jul 2011 17:44:09 +0200

On Mon, Jul 11, 2011 at 04:20:38PM +0100, Philip Martin wrote:
> Philip Martin <philip.martin_at_wandisco.com> writes:
>
> > However this object code is dynamically loaded by Perl at runtime so
> > it's not impossible that the Perl compiler flags need to be applied. It
> > seems to me that Subversion is responsible for ensuring that this is
> > done and that we should be fixing this in Subversion.
>
> I propose to compile with both Subversion and Perl flags using the
> following patch:

Fine with me if this helps.

This won't prevent problems if flags used by Perl override flags used
by Subversion in some bad way. But I have no better idea to offer either.

> Index: subversion/bindings/swig/perl/native/Makefile.PL.in
> ===================================================================
> --- subversion/bindings/swig/perl/native/Makefile.PL.in (revision 1145056)
> +++ subversion/bindings/swig/perl/native/Makefile.PL.in (working copy)
> @@ -60,7 +60,7 @@
> my %config = (
> ABSTRACT => 'Perl bindings for Subversion',
> DEFINE => $cppflags,
> - CCFLAGS => $cflags,
> + CCFLAGS => join(' ', $cflags, $Config{ccflags}),
> INC => join(' ',$apr_cflags, $apu_cflags,
> " -I$swig_srcdir/perl/libsvn_swig_perl",
> " -I$svnlib_srcdir/include",
>
> --
> uberSVN: Apache Subversion Made Easy
> http://www.uberSVN.com
Received on 2011-07-11 17:44:50 CEST

This is an archived mail posted to the Subversion Dev mailing list.