[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1144530 - /subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c

From: Daniel Shahaf <d.s_at_daniel.shahaf.name>
Date: Sat, 9 Jul 2011 03:57:15 +0300

Blair Zajac wrote on Fri, Jul 08, 2011 at 17:52:26 -0700:
> On 7/8/11 4:34 PM, Daniel Shahaf wrote:
> >Blair Zajac wrote on Fri, Jul 08, 2011 at 15:50:17 -0700:
> >>On Jul 8, 2011, at 3:44 PM, danielsh_at_apache.org wrote:
> >>>+++ subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c Fri Jul 8 22:44:52 2011
> >>>@@ -6509,8 +6509,7 @@ commit_body(void *baton, apr_pool_t *poo
> >>> new_dir, pool));
> >>> }
> >>>
> >>>- if (ffd->format< SVN_FS_FS__MIN_PACKED_REVPROP_FORMAT ||
> >>>- new_rev>= ffd->min_unpacked_revprop)
> >>>+ assert(! is_packed_revprop(cb->fs, new_rev));
> >>
> >>Wouldn't an SVN_ERR_ASSERT() be better here?
> >
> >Works for me. What about those other instances --- in
> >write_change_entry() and recover_find_max_ids()?
>
> +1.
>

r1144563.

> Blair
Received on 2011-07-09 02:58:06 CEST

This is an archived mail posted to the Subversion Dev mailing list.