[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1144530 - /subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c

From: Blair Zajac <blair_at_orcaware.com>
Date: Fri, 8 Jul 2011 15:50:17 -0700

On Jul 8, 2011, at 3:44 PM, danielsh_at_apache.org wrote:

> Author: danielsh
> Date: Fri Jul 8 22:44:52 2011
> New Revision: 1144530
>
> URL: http://svn.apache.org/viewvc?rev=1144530&view=rev
> Log:
> Repeat r1143899 elsewhere in the same function.
>
> * subversion/libsvn_fs_fs/fs_fs.c
> (commit_body): Creating a revprops shard has always been orthogonal
> of packing, since we have not implemented packing of non-completed
> shards or just-committed revisions. Accordingly, replace an if() with
> an assert().
>
> Modified:
> subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c
>
> Modified: subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c
> URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c?rev=1144530&r1=1144529&r2=1144530&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c (original)
> +++ subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c Fri Jul 8 22:44:52 2011
> @@ -6509,8 +6509,7 @@ commit_body(void *baton, apr_pool_t *poo
> new_dir, pool));
> }
>
> - if (ffd->format < SVN_FS_FS__MIN_PACKED_REVPROP_FORMAT ||
> - new_rev >= ffd->min_unpacked_revprop)
> + assert(! is_packed_revprop(cb->fs, new_rev));

Wouldn't an SVN_ERR_ASSERT() be better here?

Blair
Received on 2011-07-09 00:50:55 CEST

This is an archived mail posted to the Subversion Dev mailing list.