[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

RE: svn commit: r1143860 - /subversion/trunk/subversion/libsvn_ra_serf/update.c

From: Bert Huijben <bert_at_qqmail.nl>
Date: Thu, 7 Jul 2011 17:10:58 +0200

> -----Original Message-----
> From: ivan_at_apache.org [mailto:ivan_at_apache.org]
> Sent: donderdag 7 juli 2011 16:55
> To: commits_at_subversion.apache.org
> Subject: svn commit: r1143860 -
> /subversion/trunk/subversion/libsvn_ra_serf/update.c
>
> Author: ivan
> Date: Thu Jul 7 14:55:19 2011
> New Revision: 1143860
>
> URL: http://svn.apache.org/viewvc?rev=1143860&view=rev
> Log:
> Fix calculation X-SVN-VR-Base request header in ra_serf.
>
> This commit reverts r1142065 and r1143089.
>
> * subversion/libsvn_ra_serf/update.c
> (report_dir_t): Remove repos_relpath.
> (report_context_t): Remove root_is_switched.
> (start_report): Do not update repos_relpath.
> (end_report): Use only wcprops as source for delta base. Our current
> protocol doesn't gives us stable way to construct delta base without
> wcprops. We can optimize it later.

You just removed the stable way to retrieve these paths..

The reporting phase of an update was designed (probably in 2000-2001) to exactly handle this: In the report phase the working copy tells the repository/server exactly how a switched working copy looks like and what revisions each node has.

The idea of HTTPv2 was to deprecate the dav props by using this knowledge and how the urls are constructed.
My patch allowed that by providing the missing pieces. Your patch makes dav props required again. (So maybe it reverted the original idea of HTTPv2?)

Can you explain why reverting this was necessary?

        Bert
Received on 2011-07-07 17:11:37 CEST

This is an archived mail posted to the Subversion Dev mailing list.