[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: fsfs revprop packing in f5 Re: Does fsfs revprop packing no longer allow usage of traditional backup software?

From: Peter Samuelson <peter_at_p12n.org>
Date: Wed, 6 Jul 2011 14:45:33 -0500

[Hyrum K Wright]
> In addition, the revprop packfile manifest information won't be
> cached, since the manifest may change. We don't anticipate this to
> be a problem, since it only adds an extra seek() to the revprop
> lookup process (rather than the open() + seek() in the rev packing
> world).

Eh ... if editing revprops is accomplished by writing a whole new shard
and then renaming, then you most definitely _do_ need an open() in
there, if you think there may be changes. (Or, at the very least,
stat() and check the st_ino field to see if it has changed.)

Also, as I understand it, you can't easily delete a file, on Windows,
that someone else has open, even just for reading. So that might make
the whole 'atomic rename' business a bit more exciting.

Just sayin',
Peter
Received on 2011-07-06 21:46:15 CEST

This is an archived mail posted to the Subversion Dev mailing list.