Re: svn commit: r1141845 - /subversion/trunk/subversion/mod_dav_svn/util.c

On Fri, Jul 1, 2011 at 18:14, Bert Huijben <bert_at_qqmail.nl> wrote:
>> -----Original Message-----
>> From: ivan_at_visualsvn.com [mailto:ivan_at_visualsvn.com] On Behalf Of Ivan
>> Zhakov
>> Sent: vrijdag 1 juli 2011 10:05
>> To: Subversion Development
>> Subject: Re: svn commit: r1141845 -
>> /subversion/trunk/subversion/mod_dav_svn/util.c
>>
>> On Fri, Jul 1, 2011 at 11:15,  <ivan_at_apache.org> wrote:
>> > Author: ivan
>> > Date: Fri Jul  1 07:15:26 2011
>> > New Revision: 1141845
>> >
>> > URL: http://svn.apache.org/viewvc?rev=1141845&view=rev
>> > Log:
>> > mod_dav_svn: Accept HTTPv2 style URIs in X-SVN-VR-Base header. This
>> fixes
>> > problem that ra_serf client downloads full texts, instead of deltas when
>> > working with HTTPv2 enabled server.
>> >
>> This commit broke external_tests #25. It seems to be client side bug
>> in ra_serf, I'm going to investigate it today.
>
> I created a patch for this issue, but before committing Ivan asked a bit more time to investigate if this is the right way to fix this problem.
>
The problem that client cannot figure out URI of delta base to use.
Actually subversion/ra_serf/update.c:1876 has big #if 0 block with
FIXME that it should be fixed, but nobody fixed it before :)

I see only one proper way to fix the problem: Introduce
X-SVN-Base-Revision request header to specify base revision instead of
arbitrary URI (X-SVN-VR-Base). But we definitely have to fix this
before svn 1.7, because now Subversion over ra_serf retrieves full
text instead of deltas on each update.

Since I don't have a chance to work on this issue on weekend I
reverted my change in r1141995 just to make buildbots green.

Btw during testing I found that externals_tests #25 over ra_neon also
fails if "SVNAllowBulkUpdates off" is configured on server.

-- 
Ivan Zhakov
VisualSVN Team