Re: recover_body() ### What if rNNN legitimately has no revprops? was: Re: Does fsfs revprop packing no longer allow usage of traditional backup software?

Daniel Shahaf <danielsh_at_elego.de> writes:

> Philip Martin wrote on Thu, Jun 30, 2011 at 19:48:25 +0100:
>> for i in $(seq 0 $(svnlook youngest repo)) ; do
>> sqlite3 repo/db/revprops/revprops.db "insert into revprop values ($i, '()'"
>> done
>>
>
>>From recover_body():
>
> /* No file? Hrm... maybe that's because this repository is
> packed and the youngest revision is in the revprops.db
> file? We can at least see if that's a possibility.
>
> ### TODO: Could we check for revprops in the revprops.db?
> ### What if rNNN legitimately has no revprops? */
>
>
> Your excerpt implies the answer to the first ###'d question is "Yes"
> (via looking for an empty skel), doesn't it?

I don't understand your question. The properties column is "NOT NULL"
so must have some value. Are you saying we don't need rows? I guess my
use of youngest is wrong, it should stop at the last packed rev. I
haven't actually run that script, I just wrote it in my email client :)

-- 
Philip