Re: Static code analysis (cppcheck)

Julian Foad <julian.foad_at_wandisco.com> writes:

>> To remove the warning I suppose we could drop the app variable, i.e.
>>
>> new QCoreApplication(...)
>>
>> instead of
>>
>> app = new QCoreApplication(...)
>>
>> but that might prompt other warnings.
>
> The existing code creates the object and (though it never uses its
> address) never destroys it. With your change, the object would be
> created and then immediately destroyed. That doesn't seem likely to be
> what's needed, though I'm not sure exactly what is needed here.

No, it would not be immediately destroyed. Code outside Subversion may
destroy it via the singleton interface, but in most cases it will exist
until the application terminates.

-- 
Philip