[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1140505 - /subversion/trunk/subversion/libsvn_subr/io.c

From: Greg Stein <gstein_at_gmail.com>
Date: Tue, 28 Jun 2011 06:14:14 -0400

On Jun 28, 2011 5:55 AM, <stsp_at_apache.org> wrote:
>
> Author: stsp
> Date: Tue Jun 28 09:55:04 2011
> New Revision: 1140505
>
> URL: http://svn.apache.org/viewvc?rev=1140505&view=rev
> Log:
> stats++
> * subversion/libsvn_subr/io.c
> (svn_io_get_dir_filenames, temp_file_create): Fix indentation fallout
from
> the svn_error_return() -> svn_error_trace() rename. (Why didn't we call
it
> svn_error_traced()?)

Because 'trace' is active, representing what is occurring at that moment.
'traced' is historical/passive and does not represent the action.

Proper naming is better than inconvenience :-)

Cheers,
-g
Received on 2011-06-28 12:14:59 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.