Re: svn commit: r1139573 - /subversion/trunk/subversion/libsvn_ra_serf/util.c

On Sat, Jun 25, 2011 at 23:14, Greg Stein <gstein_at_gmail.com> wrote:
> On Sat, Jun 25, 2011 at 13:23,  <jerenkrantz_at_apache.org> wrote:
>>...
>> +++ subversion/trunk/subversion/libsvn_ra_serf/util.c Sat Jun 25 17:23:28 2011
>>...
>> @@ -227,8 +230,22 @@ ssl_server_cert(void *baton, int failure
>>
>>   svn_failures = ssl_convert_serf_failures(failures);
>>
>> +  /* Try to find matching server name via subjectAltName first... */
>> +  if (san) {
>> +      int i;
>> +      for (i = 0; i < san->nelts; i++) {
>> +          char *s = APR_ARRAY_IDX(san, i, char*);
>> +          if (apr_fnmatch(s, conn->hostinfo,
>> +                          APR_FNM_PERIOD) == APR_SUCCESS) {
>
> Why apr_fnmatch() here? These aren't filenames. Shouldn't this just be
> a case-insensitive string compare?
>
I think because of wildcard certificates, e.g *.example.com.

-- 
Ivan Zhakov