[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1132968 - in /subversion/trunk/subversion/include: svn_types.h svn_version.h

From: Greg Stein <gstein_at_gmail.com>
Date: Thu, 23 Jun 2011 15:00:56 -0400

On Tue, Jun 7, 2011 at 08:14, <rhuijben_at_apache.org> wrote:
> Author: rhuijben
> Date: Tue Jun  7 12:14:14 2011
> New Revision: 1132968
> URL: http://svn.apache.org/viewvc?rev=1132968&view=rev
> Log:
> Following up on r1132965, just move the type. This matches how we handled the
> problem for svn_error_t.
> * subversion/include/svn_types.h
>  (svn_version_t): Add full definition here.
> * subversion/include/svn_version.h
>  (svn_version_t): And remove it here.

I've been thinking more on this change and absolutely hate it.

We have a header DEDICATED to this structure and its concepts. The
structure should be in that header file. It makes no sense to have a
dedicated header, yet to move its key structure somewhere else.

Please revert this change.

Received on 2011-06-23 21:01:29 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.