[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1138516 - /subversion/trunk/subversion/libsvn_client/ra.c

From: Stefan Sperling <stsp_at_elego.de>
Date: Wed, 22 Jun 2011 22:53:13 +0200

On Wed, Jun 22, 2011 at 04:43:38PM -0400, Greg Stein wrote:
> Is there a way that this can be tested? ie. avoid similar situations
> in the future?

I don't know. I came across this because I saw code that did:

 peg_rev = INVALID_REVNUM;
 /* do nothing with peg_rev */
 if (peg_rev == INVALIV_REVNUM)

Which is obviously bogus so I praised the file at various revisions
until I found the cause. I don't know more than that :)

But I agree our tests should have caught this if it is important.
Received on 2011-06-22 22:53:50 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.