Re: [PATCH] Fix for issue 3813

Greg Hudson wrote on Wed, Jun 22, 2011 at 11:01:05 -0400:
> On Wed, 2011-06-22 at 02:29 -0400, Daniel Shahaf wrote:
> > From looking at the code, svn_io_open_unique_file3() would force the
> > file to have a mode of 0600|umask() instead of just 0600
>
> The umask removes file permissions from the mode argument to open(); it
> doesn't add permissions. (Unless there's something unusual about this
> code.)

The comments in the code are of the form "This is a hack to make the
file created with mode 0644 rather than 0600 as it was without/before
this hack". My '0600|umask()' syntax is inaccurate.

(It's 0600|foo(), but foo() != umask().)
Received on 2011-06-22 17:09:25 CEST