Re: svn commit: r1138375 - /subversion/trunk/build/ac-macros/apache.m4
[ dang: also send to dev@ ]
On Wed, Jun 22, 2011 at 07:02, Greg Stein <gstein_at_gmail.com> wrote:
> On Wed, Jun 22, 2011 at 06:21, Philip Martin <philip.martin_at_wandisco.com> wrote:
>> philip_at_apache.org writes:
>>> Author: philip
>>> Date: Wed Jun 22 10:09:17 2011
>>> New Revision: 1138375
>>> URL: http://svn.apache.org/viewvc?rev=1138375&view=rev
>>> * build/ac-macros/apache.m4
>>> (SVN_FIND_APACHE): Fix APR version checking, it was erroneously
>>> checking for any one character in the rather than the whole
>>> line. Make Apache-2.4 a requirement for using APR-2.
> The above sentence needs editing.
>> Subversion's configure attempts to check that the Apache used to build
>> mod_dav_svn is compatible with the APR used to build Subversion. It
>> compares version numbers:
>> Using APR 0.x requires Apache 2.0
>> Using APR 1.x requires Apache 2.[1-4]
>> It is not checking that Apache and Subversion use the same APR. Does
>> that mean we support Subversion/mod_dav_svn built using one version of
>> APR while Apache uses a different version?
>> Should we instead check that Subversion and Apache use the same APR? We
>> could do it by checking that "apxs2 -q APR_CONFIG" matches apr_config
>> found by configure.
> The server side needs to match httpd's APR. The client side can be different.
> Personally, I say that if you find httpd, then mandate its APR
> throughout the build. It is simplest that way. If somebody wants to
> get crazy and provide two different APRs based on client vs server,
> then let them monkey the configuration.
Received on 2011-06-22 13:03:18 CEST
This is an archived mail posted to the Subversion Dev