Re: 1.7.0-alpha1 feedback (Issue #3933)

On Tue, Jun 21, 2011 at 12:30:48PM +0200, Bert Huijben wrote:
> This error is raised in the ra layer (Inside svn_ra_reparent) where you have
> a connection to a single repository via its url: In that location it should
> fail on every url not pointing to exactly the same repository.

Right. I'm not sure why an external causes a reparent operation
rather than a new session. But I agree that it makes sense for
reparent to require that the URL to the repository root is unchanged.

> I think this issue is caused by the ra_serf code that removes default port
> numbers when you connect to a repository by using APR. Neon used its own
> rules so it wouldn't fail.

I could reproduce the problem with Neon, though.

> But with our strict rules that any uri passed to our apis must be canonical,
> we shouldn't see this problem.
>
>
> But as I found out (and fixed in r1137927) our uri canonicalization for user
> provided uris didn't check port numbers at all.

Great! I can confirm that it fixes the reported problem.
Received on 2011-06-21 12:49:31 CEST