Re: svn commit: r1137120 - /subversion/trunk/subversion/libsvn_ra_serf/util.c

On Mon, Jun 20, 2011 at 18:49, Ivan Zhakov <ivan_at_visualsvn.com> wrote:
> On Sat, Jun 18, 2011 at 07:37,  <gstein_at_apache.org> wrote:
>...
>> +      err = inject_to_parser(parser, pb->data, len, NULL);
>> +      if (err)
>> +        break;
>> +
>> +      /* If there is no more content (for now), or the callbacks paused
>> +         the parsing, then we're done.  */
>> +      if (APR_STATUS_IS_EOF(status) || parser->paused)
>> +        break;
>> +    }
>> +
>
> You have to seek to the end after injecting parser in you paused (or
> on error) since write_pending assumes that file position is at the end
> of file.

Yup, I was planning to seek near the code that calls
write_to_pending() (the response handler, reading from the network). I
guess that I could do it here, too. I'll ponder if there is an
advantage to one place or the other.

Cheers,
-g
Received on 2011-06-21 01:57:50 CEST