[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: svn commit: r1136838 - /subversion/trunk/subversion/libsvn_client/commit_util.c

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Fri, 17 Jun 2011 10:26:39 -0400

On 06/17/2011 07:01 AM, Bert Huijben wrote:
> I think this is a HTTPv2 limitation: In HTTPv1 we used to perform a
> checkout on open_directory() where we (somehow) passed the base_revision
> and got an out-of-date report.
> With HTTPv2 we only pass the base revision to proppatch, so the out of
> date check for files only works on the MD5 hash we sent for the update.
> (So theoretically we might see issues on MD5 collisions)
> I think we should at least verify the base_revision somewhere in the PUT
> code path.

We are including the base revision in the PUT request, right? (See
libsvn_ra_serf/commit.c:setup_put_headers(), for example.) Are you saying
that mod_dav_svn isn't verifying it?

C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on 2011-06-17 16:27:13 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.