Hi Stefan -
On Wed, Jun 15, 2011 at 9:23 AM, Stefan Sperling <stsp_at_elego.de> wrote:
>
> Committed in r1136063.
Thank you!
>
>> > Also, did you already run the regression tests with your patch ("make
>> > check")? My suggestion might affect the output of 'svn' so tests would
>> > need to be run again (but I will run them either way before committing).
>>
>> I did not.
>
> They all pass.
>
If you think we need to add a test for this bug maybe I could work one
up. Although at first glance this appears a bit daunting (to me).
>> BTW, I really have to hand it to you guys for putting together some
>> nice online docs that explains your development process and the
>> awesome Makefile.svn which allows a new developer to get started with
>> the code so quickly.
>
> Glad to hear that Makefile.svn is useful to others, too.
> I originally used it as my local build script and Hyrum suggested
> to put in our repo in case someone finds it useful. Now there we go :)
>
I probably not would have been able to write the initial patch without
it. Once I had all the pre-requisite build tools installed in Ubuntu,
all I had to do was type "make" and watch it go to town. It was
amazing. The only thing that kind of tripped me up was that I am using
Ubuntu 10.04, which uses svn 1.6 to checkout the working copy of svn.
So at the end, when it does a svnversion I got some strange error
about my working copy being too old. But after googling I convinced
myself I could ignore this error. So yes, thank for that Makefile,
it's very useful in lowering the barrier to contributing.
Best regards,
BN
Received on 2011-06-15 21:23:24 CEST