Re: API review - mod_*.h, svn_auth ... svn_hash.h

An update on my observations on this batch of headers. I am updating
<notes/api-changes-1.7.txt> to reflect this too.

On Thu, 2011-06-09, I (Julian Foad) wrote:
> svn_cache_config.h
> # Why is the cache config header separate from the cache header?

Was answered to my satisfaction.

> svn_get_cache_config()
> svn_set_cache_config()
> # Rename these two to svn_cache_config_*().

Done.

> svn_checksum.h
> svn_checksum_mismatch_err()
> # Make this private, as it's not general-purpose enough?

Idea rejected.

> svn_config.h
> SVN_CONFIG_OPTION_DIFF_EXTENSIONS "diff-extensions"
> SVN_CONFIG_OPTION_FORCE_USERNAME_CASE "force-username-case"
> # These two need @since.

Done.

> svn_dav.h
> SVN_SKEL_MIME_TYPE "application/vnd.svn-skel"
> # Need @since.

Done.

> SVN_DAV_..._HEADER "SVN-..."
> # 12 new constants, mostly for HTTP protocol v2.
> # Need @since.

Done.

> svn_delta.h
> SVN_NO_COMPRESSION_LEVEL 0
> SVN_MAX_COMPRESSION_LEVEL 9
> SVN_DEFAULT_COMPRESSION_LEVEL 5
> # Use a library prefix SVN_DELTA for these three.
> # Use a common prefix *_COMPRESSION_LEVEL for these three.

Done.

> svn_diff.h
> svn_diff_fns2_t
> # Needs @since.

Done.

> svn_dirent_uri.h
> # Rename 'dirent' to something like 'ospath'? Too late, I guess.

Idea abandoned.

> svn_relpath_internal_style()
> svn_relpath_local_style()
> # These two are inappropriate: only dirents have a 'local' style.

One made private, the other removed. Details elsethread.

> svn_uri_is_root()
> # Document what "is root" means: "can't split into dir/basename"?

TODO.

> svn_dirent_skip_ancestor()
> # See ### comment.

TODO. Details elsethread.

> svn_relpath_skip_ancestor()
> # See ### comment.
> svn_uri_skip_ancestor()

Done - both relpath and uri versions.

> svn_error.h
> svn_error_return()
> # Needs @since.

Done.

> svn_error_codes.h
> SVN_ERR_WC_CHANGELIST_MOVE - now deprecated
> # Should say "for compatibility with 1.6 API".

Done.

- Julian
Received on 2011-06-15 18:35:06 CEST