[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: SVN 1.7.0. alpha source code

From: C. Michael Pilato <cmpilato_at_collab.net>
Date: Wed, 15 Jun 2011 00:05:55 -0400

On 06/14/2011 08:25 PM, Konstantin Kolinko wrote:
> Looking at the mirrors.cgi script at
> /site/trunk/content/dyn/mirrors/mirrors.cgi at the above link, I
> think there is a bug there.
> There is the following code fragment in parse_mirrors():
> # Check if the requested Preferred mirror is in the list
> # Note the user-requested mirror doesn't have a trailing-slash
> prefmir=None
> if preferred:
> for mir in mirrors:
> if mir[2][:-1]==preferred:
> prefmir=mir
> break
> The "the user-requested mirror doesn't have a trailing-slash" comment
> is wrong and thus the code following it is wrong.

I could have sworn that I tested this theory and found it bogus earlier
today, but sure enough when I hit ...


... instead of ...


... I get the proper behavior.

> So I think the following patch will fix this (not tested):

I, too, suspect your patch will fix it (also not tested).

C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand

Received on 2011-06-15 06:06:31 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.