Re: SVN 1.7.0. alpha source code

On 06/14/2011 08:25 PM, Konstantin Kolinko wrote:
> Looking at the mirrors.cgi script at
> /site/trunk/content/dyn/mirrors/mirrors.cgi at the above link, I
> think there is a bug there.
>
> There is the following code fragment in parse_mirrors():
>
> # Check if the requested Preferred mirror is in the list
> # Note the user-requested mirror doesn't have a trailing-slash
> prefmir=None
> if preferred:
> for mir in mirrors:
> if mir[2][:-1]==preferred:
> prefmir=mir
> break
>
> The "the user-requested mirror doesn't have a trailing-slash" comment
> is wrong and thus the code following it is wrong.

I could have sworn that I tested this theory and found it bogus earlier
today, but sure enough when I hit ...

http://httpd.apache.org/download.cgi?Preferred=http%3A%2F%2Fapache.ziply.com

... instead of ...

http://httpd.apache.org/download.cgi?Preferred=http%3A%2F%2Fapache.ziply.com%2F

... I get the proper behavior.

> So I think the following patch will fix this (not tested):

I, too, suspect your patch will fix it (also not tested).

-- 
C. Michael Pilato <cmpilato_at_collab.net>
CollabNet   <>   www.collab.net   <>   Distributed Development On Demand