[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: SVN 1.7.0. alpha source code

From: Tony Stevenson <pctony_at_apache.org>
Date: Tue, 14 Jun 2011 21:08:05 +0100

Hash: SHA256

On 14 Jun 2011, at 21:05, C. Michael Pilato wrote:

> On 06/14/2011 03:41 PM, sebb wrote:
>> Looks like the Change button just selects a random entry from the
>> list, rather than applying the selected entry.
> Yes, that's the apparent action. In reality, the default action is "select
> a random mirror", so I suspect that this isn't so much the direct result of
> the Change button being used as it is just a side-effect of the Preferred
> server selection not "taking".
> See, the Change button is just a submit button. The
> "?Preferred=SELECTED_ITEM" bit added to the form submission URL is the
> natural behavior for the select box named "Preferred" and whose values come
> directly from the options therein. The mirrors.cgi is supposed to notice
> that bit in the URL query string, validate the preferred URL against the
> configured set of mirrors, and then -- if all is well in that validation
> step -- substitute that preferred URL unto the EZT template (download.html
> in our tree). That's clearly not happening.
> I wonder if this script was originally written for CGI and then something
> got fouled up during some retrofitting for WSGI? Maybe some misinteraction
> with the script environment?

This is possible, the download.cgi scripts did get a fair bit of attention a while back, and I cant recall what happened exactly, so I will have to trawl through my mail archives for that, if you have any ideas let me know. If not, I'll add it to my todo.

> --
> C. Michael Pilato <cmpilato_at_collab.net>
> CollabNet <> www.collab.net <> Distributed Development On Demand


- ---------------------------------------
Tony Stevenson

tony_at_pc-tony.com // pctony_at_apache.org


GPG - 1024D/51047D66
- --------------------------------------

Version: GnuPG/MacGPG2 v2.0.17 (Darwin)
Comment: GPGTools - http://gpgtools.org

Received on 2011-06-14 22:21:02 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.