[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Simplify and optimize RA-svn's string marshalling

From: Stefan Fuhrmann <stefanfuhrmann_at_alice-dsl.de>
Date: Tue, 14 Jun 2011 20:13:54 +0200

On 03.06.2011 10:52, Julian Foad wrote:

> Hi Stefan2 and others.
> This patch simplifies code in RA-svn/marshal.c by using a single code
> path to read both short and long strings efficiently. Using a single
> code path is beneficial for test coverage.
> It is an alternative to r1028352 which merged r985606 and r1028092 from
> the performance branch.
> I have run the test suite over RA-svn (with BDB) but haven't done any
> more testing than that. It's just something I noticed while looking at
> that code, it's not solving a problem I've noticed or anything like
> that. By inspection I believe it is more efficient than
> read_long_string() was, and unchanged for short strings, but if you're
> able to do any performance analysis on it, that would be great.
Following the discussion elsewhere in this thread,
I decided not to limit the size of strings transmittable
over svn just yet. Let's focus on getting 1.7 out of
the door without introducing new pitfalls ;)

Committed as r1135210 (after some fine-tuning).

-- Stefan^2.
Received on 2011-06-14 20:16:20 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.