Re: API review - svn_sorts ... svn_xml.h

Julian Foad wrote on Mon, Jun 13, 2011 at 16:22:20 +0100:
> This is a list of all the changes to public symbols, with a few drive-by
> remarks. Comparing 1.6.17 to trunk_at_1134000; I'll check for any
> subsequent changes on trunk later.
>
> svn_types.h
> + SVN_UNALIGNED_ACCESS_IS_OK
> + svn_version_t - moved to here from svn_version.h
> ! svn_node_kind_t - gets an enum tag name to match typedef
> + svn_tristate_t
> + svn_tristate_to_word()
> # Are the strings localized or fixed? Make private?
> + svn_tristate_from_word()
> # Are the strings localized or fixed? Make private?

The docstrings say fixed strings.

but there is another problem, the docstring implies that
svn_tristate_from_word("yes") == svn_tristate_unknown, but the
implementation behaves differently.
Received on 2011-06-13 18:03:53 CEST