[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] possible improvement to svn log with "forward" revision range (issue 3830)

From: Dirk Thomas <websvn_at_dirk-thomas.net>
Date: Mon, 13 Jun 2011 16:46:15 +0200

Thank you for your feedback, Philip.
I have attached an updated patch.

> A short comment along the lines 'Sets *REVISION_DELETED ...'

I have added a comment for function check_for_deleted_rev.

> No whitespace before ')'.
> Split long line before '&& session_opt_revnum'

I have updated the formatting of the source code.

> You don't clear err, so if the following two calls return an error then
> err leaks.

I have modified the logic how the errors are handled (and now correctly cleared).

I needed to introduce an error when the REVISION_DELETED can not be determined:
   return svn_error_create
      _("Could not determine revision where target was deleted"));

> A temporary session is used to identify the deleted revision, and then
> another session is created to run log. Since the temporary session
> "works" could it be permanent and used for log?

I have modified the code to reuse the iterpool which is later used for fetching the log.
I hope it is used correctly - i am not very familiar with this stuff yet.

Is there any more feedback which i should integrate?


  • text/x-patch attachment: stored
Received on 2011-06-13 16:46:52 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.