[svn.haxx.se] · SVN Dev · SVN Users · SVN Org · TSVN Dev · TSVN Users · Subclipse Dev · Subclipse Users · this month's index

Re: [PATCH] Issue #3919: fix for spurious property conflict during merge

From: Brian Neal <bgneal_at_gmail.com>
Date: Sun, 12 Jun 2011 11:04:24 -0500

On Sat, Jun 11, 2011 at 11:36 PM, noorul Islam. Kamal Malmiyoda
<noorul_at_collab.net> wrote:
>
>> <issue3919.txt>
>
> I think conditions can be combined to form one "if" statement without "else if".
>
> Thanks and Regards
> Noorul

Hello -

I'm not sure I follow you, can you please explain a bit more? I'm not
sure how you could capture all 3 cases without an else-if.

I probably could change it from an "if/else if/else" to an "if/else
if", but I would have to repeat a condition test in both the "if" and
"else if" parts. Because of that, I feel the current patch is more
readable even if it takes a little more vertical space.

Thanks for the feedback and best regards,
BN
Received on 2011-06-12 18:04:58 CEST

This is an archived mail posted to the Subversion Dev mailing list.

This site is subject to the Apache Privacy Policy and the Apache Public Forum Archive Policy.