RE: svn commit: r1134084 - /subversion/trunk/subversion/libsvn_wc/workqueue.c

> -----Original Message-----
> From: gstein_at_apache.org [mailto:gstein_at_apache.org]
> Sent: donderdag 9 juni 2011 23:17
> To: commits_at_subversion.apache.org
> Subject: svn commit: r1134084 -
> /subversion/trunk/subversion/libsvn_wc/workqueue.c
>
> Author: gstein
> Date: Thu Jun 9 21:17:29 2011
> New Revision: 1134084
>
> URL: http://svn.apache.org/viewvc?rev=1134084&view=rev
> Log:
> After r1133773, we need to ensure the work item has been marked as
> completed before we exit the loop (via cancellation). Technically, a work
> item can be run multiple times, but let's not be gratuitous about it :-)

        Thanks,

I think this should fix some extreme corner cases which we wouldn't find by normal testing.

Usually the operation would be cancelled somewhere while performing the actual workitem (which would be tested sometimes by an accidental ^C), but the last part of an operation like recording the timestamp is usually too short to find this in normal testing.
(But with millions of users, some of them will notice)

        Bert
Received on 2011-06-10 09:08:35 CEST