[PATCH] is (null) gnome keyring locked?

My system 1.6 client (Debian package) often prompts me:

[[[
Password for '(null)' GNOME keyring:
]]]

I'm guessing that the following patch will sort the issue:

[[[
Index: subversion/libsvn_auth_gnome_keyring/gnome_keyring.c
===================================================================
--- subversion/libsvn_auth_gnome_keyring/gnome_keyring.c (revision 1133273)
+++ subversion/libsvn_auth_gnome_keyring/gnome_keyring.c (working copy)
@@ -171,6 +171,10 @@ check_keyring_is_locked(const char *keyring_name)
 {
   struct gnome_keyring_baton key_info;
 
+ /* Fast exit. */
+ if (! keyring_name)
+ return FALSE;
+
   key_info.info = NULL;
   key_info.keyring_name = NULL;
 
]]]

... but I can't reproduce the original error with my trunk client, so
I'm not sure the patch is correct.

Thoughts?

Daniel
(I have --config-option=config:auth:password-stores="" in effect)
Received on 2011-06-09 21:25:10 CEST