On Sun, Jun 5, 2011 at 2:40 PM, Johan Corveleyn <jcorvel_at_gmail.com> wrote:
> externals_tests.py 29 'update a file external without committing
> target' is still marked as XFail, but the issue mentioned there (#3823
> - 'update' update file external without commit is broken) is marked as
> Fixed.
Hi Johan,
Spotted the same while reviewing our current crop of XFailing tests:
http://svn.haxx.se/dev/archive-2011-05/1075.shtml
Bert is working on this presently.
Paul
> What's going on? Is the @Issue annotation wrong in externals_tests.py?
> Or is the issue not fixed?
>
> What's more: the test causes an assertion to fail on my system, which
> should probably be fixed even if we leave this behavior broken as
> "known issue":
>
> [[[
> Updating 'svn-test-work\working_copies\externals_tests-29':
>
> Fetching external item into
> 'svn-test-work\working_copies\externals_tests-29\A2\iota':
> svn: E235000: In file '..\..\..\subversion\libsvn_wc\workqueue.c' line
> 672: assertion failed (checksum != NULL)
>
> This application has requested the Runtime to terminate it in an unusual way.
> Please contact the application's support team for more information.
> Traceback (most recent call last):
> File "C:\research\svn\client_build\svn_trunk\subversion\tests\cmdline\svntest\main.py",
> line 1288, in run
> rc = self.pred.run(sandbox)
> File "C:\research\svn\client_build\svn_trunk\subversion\tests\cmdline\svntest\testcase.py",
> line 114, in run
> return self._delegate.run(sandbox)
> File "C:\research\svn\client_build\svn_trunk\subversion\tests\cmdline\svntest\testcase.py",
> line 176, in run
> return self.func(sandbox)
> File "C:\research\svn\client_build\svn_trunk\subversion\tests\cmdline\externals_tests.py",
> line 1715, in file_external_update_without_commit
> sbox.simple_update()
> File "C:\research\svn\client_build\svn_trunk\subversion\tests\cmdline\svntest\sandbox.py",
> line 197, in simple_update
> svntest.main.run_svn(False, 'update', target)
> File "C:\research\svn\client_build\svn_trunk\subversion\tests\cmdline\svntest\main.py",
> line 591, in run_svn
> *(_with_auth(_with_config_dir(varargs))))
> File "C:\research\svn\client_build\svn_trunk\subversion\tests\cmdline\svntest\main.py",
> line 347, in run_command
> None, *varargs)
> File "C:\research\svn\client_build\svn_trunk\subversion\tests\cmdline\svntest\main.py",
> line 523, in run_command_stdin
> raise Failure
> Failure
> XFAIL: externals_tests.py 29: update a file external without committing target
> ]]]
>
> --
> Johan
>
Received on 2011-06-08 15:23:31 CEST