On Fri, 2011-06-03, Greg Stein wrote:
> On Fri, Jun 3, 2011 at 13:33, Julian Foad <julian.foad_at_wandisco.com> wrote:
> >...
> > * svn_client_upgrade() - What versions can it upgrade from and to?
>
> Any version prior to the current.
>
> > What upgrade-specific error conditions can it encounter?
>
> Dunno
>
> > Document the
> > 'dir' parameter: e.g. does it need to be the root of a WC?
>
> Yes.
r1132593, documenting the above and renaming 'dir' to 'wcroot_dir'.
> > * svn_client_info3() - doc says 'path_or_url', param name is
> > 'abspath_or_url'; which is intended?
>
> Look at the code. The parameter name is probably correct.
r1132575.
> > * svn_client_uuid_from_path2() - since this now requires an abspath,
> > maybe rename to ..._from_abspath()? Or keep accepting a relative path.
> > Seems a bit arbitrary for these two libsvn_client APIs (this and info3)
> > to switch to requiring an abspath. Maybe they should continue to accept
> > local paths relative to the current working dir, for API consistency?
>
> abspath is best. The entire client API will change to use abspath at
> some point. We can certainly start on that with the new APIs.
OK.
> > * svn_info_t has grown a 'wcroot_abspath' field even though the
> > structure is being deprecated and replaced by svn_info2_t. Intentional?
>
> Probably unintentional. I bet it was added before info2 was created.
> Thus: it should be ripped out (I'm assuming nobody is using it
> nowadays).
r1132567.
Thanks.
- Julian
Received on 2011-06-06 13:02:03 CEST